Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update code from v2.5.3 (bump cometbft version, yoda handling request logic) #326

Merged
merged 7 commits into from
Sep 14, 2023
Merged

Update code from v2.5.3 (bump cometbft version, yoda handling request logic) #326

merged 7 commits into from
Sep 14, 2023

Conversation

RogerKSI
Copy link
Contributor

@RogerKSI RogerKSI commented Sep 13, 2023 •
edited
Loading

Implementation details

  • bump cometbft version
  • handling request logic

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@RogerKSI RogerKSI requested review from colmazia, taobun and satawatnack and removed request for colmazia September 13, 2023 15:27
@RogerKSI RogerKSI changed the title Update code from v2.5.3 (bump cometbft version, handling request logic) Update code from v2.5.3 (bump cometbft version, yoda handling request logic) Sep 13, 2023
@taobun taobun merged commit 1c1d384 into master Sep 14, 2023
@taobun taobun deleted the update-from-253 branch September 14, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colmazia colmazia colmazia approved these changes

@satawatnack satawatnack satawatnack approved these changes

@taobun taobun taobun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RogerKSI @taobun @satawatnack @colmazia